fix(jpms): align Automatic-Module-Name with module-info names - #401
Open
arimu1 wants to merge 1 commit into
Open
fix(jpms): align Automatic-Module-Name with module-info names#401arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
Use each module's java.module.name property for the manifest entry so core, okhttp, and retrofit no longer share dev.failsafe on the module path. Fixes failsafe-lib#386
arimu1
force-pushed
the
fix/jpms-automatic-module-name-386
branch
from
August 15, 2026 02:59
d2247ec to
909c759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${java.module.name}for theAutomatic-Module-Namemanifest entry instead of the hardcodeddev.failsafe, so each artifact gets a distinct module name on the module path.ModuleManifestTestin core, okhttp, and retrofit to guard against regressions.Problem
All Failsafe jars previously declared
Automatic-Module-Name: dev.failsafein their manifest, while moditect injects multi-releasemodule-infowith names likedev.failsafe.core,dev.failsafe.okhttp, anddev.failsafe.retrofit. When used on the JPMS module path this mismatch can cause split-package conflicts andNoClassDefFoundErrorfor types such asdev.failsafe.Policy(see #386).Test plan
mvn -pl core test -Dtest=ModuleManifestTestmvn -pl modules/okhttp,modules/retrofit -am test -Dtest=ModuleManifestTestAutomatic-Module-Name: dev.failsafe.core|okhttp|retrofitFixes #386