Skip to content

Fix spelling workflow by pinning crate-ci/typos to a valid release - #1904

Merged
nmn merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job
Sep 23, 2026
Merged

nmn merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

The spelling job in GitHub Actions was failing before execution because it referenced crate-ci/typos@master, which no longer resolves. This change updates the workflow to a supported action ref so the spelling check can run again.

  • Workflow fix

    • Updated the spelling job in .github/workflows/tests.yml to use a valid major-tag release of the action.
  • Behavioral impact

    • Restores execution of the spelling check in CI; no repo runtime/codepath changes.
- uses: crate-ci/typos@master
+ uses: crate-ci/typos@v1

Copilot AI assigned Copilot and nmn Sep 23, 2026
@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
stylex Ignored Ignored Sep 23, 2026 10:20pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2026
Co-authored-by: nmn <3582514+nmn@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job spelling Fix spelling workflow by pinning crate-ci/typos to a valid release Sep 23, 2026
Copilot AI requested a review from nmn September 23, 2026 22:21
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

workflow: benchmarks/perf

Comparison of performance test results, measured in operations per second. Larger is better.
yarn workspace v1.22.22
yarn run v1.22.22
$ node ./compare.js /tmp/tmp.y1AaLT5E2p /tmp/tmp.tkAXmpbCIn

Results Base Patch Ratio
babel-plugin: stylex.create
· basic create 586 594 1.01 +
· complex create 74 73 0.99 -
babel-plugin: stylex.createTheme
· basic themes 469 464 0.99 -
· complex themes 37 35 0.95 !!
Done in 0.07s.
Done in 0.30s.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
yarn workspace v1.22.22
yarn run v1.22.22
$ node ./compare.js /tmp/tmp.a6YvI6deQs /tmp/tmp.rBfjELDp0M

Results Base Patch Ratio
@stylexjs/stylex/lib/cjs/stylex.js
· compressed 1,535 1,535 1.00
· minified 5,166 5,166 1.00
@stylexjs/stylex/lib/cjs/inject.js
· compressed 1,793 1,793 1.00
· minified 4,915 4,915 1.00
benchmarks/size/.build/bundle.js
· compressed 496,650 496,650 1.00
· minified 4,847,840 4,847,840 1.00
benchmarks/size/.build/stylex.css
· compressed 99,735 99,735 1.00
· minified 740,755 740,755 1.00
Done in 0.08s.
Done in 0.33s.

@nmn
nmn marked this pull request as ready for review September 23, 2026 22:43
@nmn
nmn requested a review from mellyeliu as a code owner September 23, 2026 22:43
Copilot AI lite review requested due to automatic review settings September 23, 2026 22:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Updates the spelling workflow to use the valid crate-ci/typos@v1 action reference, restoring CI execution.

Changes:

  • Replaced the obsolete @master reference with @v1.
  • Preserved the existing spelling configuration.
File Description
.github/​workflows/​tests.yml Pins the spelling action to the valid v1 release tag.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nmn
nmn merged commit 07a6cf3 into main Sep 23, 2026
14 checks passed
@nmn
nmn deleted the copilot/fix-failing-github-actions-job branch September 23, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants