[types] cursor should accept arbitrary string - #1466
Open
henryqdineen wants to merge 3 commits into
Open
henryqdineen wants to merge 3 commits into
henryqdineen wants to merge 3 commits into
Conversation
henryqdineen
requested review from
ezzak,
mellyeliu,
necolas,
nmn and
vincentriemer
as code owners
January 27, 2026 15:38
|
@henryqdineen is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
This was referenced Sep 11, 2026
henryqdineen
added a commit
that referenced
this pull request
Sep 11, 2026
Worked example of the `CLOSED_DESPITE_GRAMMAR` loop, and it closes #1463. cursor: its grammar is `[ [ <url> [ <x> <y> ]? , ]* [ auto | default | ... ]]`, which admits more than keywords, but the type accepts no arbitrary string. Either add `string` in the Flow types and `(string & {})` in the definitions, or list it in CLOSED_DESPITE_GRAMMAR with a reason. `cursor` takes a comma-separated list of `url()` values before its keyword, so a union of literals can never describe it -- `cursor: 'url(cur.png) 4 12, auto'` was a type error. This is the change proposed in #1466, except the TypeScript definitions get `(string & {})` rather than a bare `string`, so all 43 cursor keywords keep autocompleting while any string is accepted. That was the thing that PR asked for and could not have while the definitions were generated from the Flow types; #1466 can be closed in favour of this. Opening the union also made its `INCOMPLETE_UNIONS` entry unreachable, since that check skips properties accepting arbitrary strings. Rather than leave a dead entry, the seven keywords it recorded are added: `hand` (the pre-standard IE spelling) and the `-moz-` and zoom variants, where StyleX had `-webkit-grab` and `-webkit-grabbing` but not their siblings. Confirmed after the change: `url(cur.png) 4 12, auto`, `-moz-grab` and `pointer` all typecheck, and the editor still offers 43 completions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
This updates the
CSSCursortype to accept arbitrary strings to address a recent bug report. The fix in this PR is to simply addstringto the union type.I personally would prefer the TypeScript union to include
| (string & {})for the improved autocomplete but right now we are generating types from Flow. This article explains the TypeScript trick in more detail. Any objections to maintaining a separate type definitions of the CSS Types so we could use that trick? Have you considered directly usingcsstype?Linked PR/Issues
Fixes #1463
Screenshots, Tests, Anything Else
Pre-flight checklist
Contribution Guidelines