[fabiodalez-dev]

Stacked on #55. Closes the gaps between #55 and the Mobile API the Pinakes 0.9.0 stack sends today, and brings 0.9.0 features to the app.

Server requirement

Pinakes 0.9.0 as on its current stack: /health.features.consultation_only (Pinakes 71514e3a), status: prenotato with start_date on POST /reservations (487ec78d), override_limits on POST /staff/reservations, and quoted exact-spelling search (#501). On an older server nothing changes: a server without consultation_only keeps tying consultation to circulation_rules as in #55, one without prenotato never sends it, and override_limits is sent only when staff tick it with the rules on.

The profile's patron type (#55) and the copy editor's consultation switch also need fabiodalez-dev/Pinakes#516, which adds patron_type to GET /me and consultation_only to staff copies and to PUT /staff/copies/{id}. Until it is merged the profile row stays hidden, every copy reads lendable, and a change of the switch is ignored by the server.

What changes

• Consultation-only copies on their own switch. Pinakes 0.9.0 split them off the rules matrix: with circulation_rules off and consultation_only on, loanable can still be false. The book page fetched the reader's rules only with circulation_rules on, so a consultation-only title offered the loan button and the request was refused after sending. InstanceFeatures now reads consultation_only (off in catalogue mode or with app access off), and the book page asks for the rules when either switch is on.
• A loan approved on a closed day. With the library closed today an auto-approved request comes back prenotato with start_date. The app read every auto-approved request as ready for pickup. A new LoanScheduled kind carries start_date, and the confirmation names the pickup day, worded as the server's message.
• Quoted searches offline. Online, quotes ask the server for the exact spelling (#501). Offline the key folds accents, and the quotes themselves were searched for, so a quoted query found nothing. SearchText.withoutSearchQuotes() drops straight and typographic quotes as the server reads them, in the text query and in the author and publisher filters (filterPattern()). An inch mark after a digit (12") stays.
• Staff reservations beyond the patron type's limits. The website's new-reservation form has "Ignora i limiti di prenotazione della tipologia del lettore" with patron-type rules on. The staff new-reservation form now has the same switch and sends override_limits: true; without it the key is left out.
• Library card barcode. Pinakes 0.9.0 prints library cards with codice_tessera as Code128 by default, and the desk and the visitor-log kiosk scan it. The profile now draws the same Code128 under the card details, black on white whatever the theme, with the ZXing core the scanner already uses. Only printable ASCII is encoded, as on the printed card.
• Consultation-only copies from the copy editor. With features.consultation_only on, the staff copy editor has the book page's switch. consultation_only is sent on PUT /staff/copies/{id} only for an existing copy and only when it changed. The server applies it through the book page's own toggle and refuses it for a copy on loan, awaiting pickup or requested.
• automatic_fines and debt_block need no client change: the server leaves accruing fines out and sends debt_block_threshold_cents: null and debt_blocked: false when they are off. They are added to _contract/health-sample.json with consultation_only. Strings in the four locales. STATUS.md updated. No Room schema change.

Tests

New unit tests: consultation_only mapping and the rules fetch (FeatureFlags090Test); prenotato parsed as LoanScheduled (LatestReleaseContractTest); quoted, typographic, unclosed and inch-mark queries (SearchTextTest) and quoted text, author and publisher on the offline database (CatalogDaoTest); the reservation override in the body only when ticked with the rules on (StaffReservationOverrideTest); the copy flag sent only when changed, for an existing copy, with the module on, and read from the server (StaffCopyConsultationTest); every card code drawn as Code128 read back with ZXing's reader, and codes Code128 cannot hold not drawn (CardBarcodeTest).

Locally: testDebugUnitTest and testReleaseUnitTest 521 tests each, none failed or skipped; lintDebug and lintRelease zero errors; assembleDebug, assembleRelease and compileDebugAndroidTestKotlin. No emulator could run here (no KVM), so the device tests were not run.

🤖 Generated with Claude Code

https://claude.ai/code/session_015Q7hZ3Sw9KSZbwUyZA34hB

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}