Repository navigation
feat(zend): add a per-request sapi activate hook - #816
Merged
Merged
Conversation
Coverage Report for CI Build 38053984402Coverage increased (+0.3%) to 75.334%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Merging this PR will not alter performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
ModuleBuilder::sapi_activate_function, which chainssapi_module.activateso a closure gets a copy of the request info at the start of every request, including each FrankenPHP worker request where RINIT does not run again, and can callset_headerfrom there. The hook goes in last at MINIT and is skipped when the user startup fails, comes back out at MSHUTDOWN when it is still the current one, and is refused fordl()modules, which PHP unloads while the SAPI would keep the pointer.Checklist