Repository navigation
test(macros): compile the macrotest expansions against ext-php-rs - #813
Merged
Merged
Conversation
Merging this PR will not alter performance
|
Coverage Report for CI Build 37989240775Coverage increased (+0.02%) to 74.503%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cargo-expand1.0.127 now fails when the expanded code does not compile (dtolnay/cargo-expand#262), and the expand tests never compiled:ext_php_rswas missing from the macrotest crate, so the snapshots recorded(/*ERROR*/)instead ofzend_fastcall!. The test now runs from the root crate whereext_php_rsis a normal dependency (a dev-dependency on the macros built a secondext_php_rsrmeta that broke skeptic), the snapshots hold the real expansion, and Windows is skipped becausezend_fastcall!expands toextern "vectorcall"there.Checklist