Skip to content

test(macros): compile the macrotest expansions against ext-php-rs - #813

Merged
ptondereau merged 2 commits into
masterfrom
test/macrotest-expand-compiles
Oct 9, 2026
Merged

ptondereau merged 2 commits into
masterfrom
test/macrotest-expand-compiles

Conversation

@ptondereau

@ptondereau ptondereau commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Description

cargo-expand 1.0.127 now fails when the expanded code does not compile (dtolnay/cargo-expand#262), and the expand tests never compiled: ext_php_rs was missing from the macrotest crate, so the snapshots recorded (/*ERROR*/) instead of zend_fastcall!. The test now runs from the root crate where ext_php_rs is a normal dependency (a dev-dependency on the macros built a second ext_php_rs rmeta that broke skeptic), the snapshots hold the real expansion, and Windows is skipped because zend_fastcall! expands to extern "vectorcall" there.

Checklist

@codspeed

codspeed Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ 45 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 45 untouched benchmarks


Comparing test/macrotest-expand-compiles (f8a9b65) with master (2cea97f)

Open in CodSpeed

@coveralls

coveralls commented Oct 9, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 37989240775

Coverage increased (+0.02%) to 74.503%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 14602
Covered Lines: 10879
Line Coverage: 74.5%
Coverage Strength: 53.63 hits per line

💛 - Coveralls

@ptondereau
ptondereau marked this pull request as ready for review October 9, 2026 22:07
@ptondereau
ptondereau merged commit 1c9a853 into master Oct 9, 2026
136 of 146 checks passed
@ptondereau
ptondereau deleted the test/macrotest-expand-compiles branch October 9, 2026 22:08
@ext-php-rs-release ext-php-rs-release Bot mentioned this pull request Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants