Repository navigation
feat(zend): add output handlers - #812
Merged
Merged
Conversation
Merging this PR will not alter performance
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| 🆕 |
output_passthroughs[1] |
N/A | 23.6 ms | N/A |
| 🆕 |
output_passthroughs[10] |
N/A | 23.6 ms | N/A |
| 🆕 |
output_passthroughs[100000] |
N/A | 155.9 ms | N/A |
| 🆕 |
output_transforms[1] |
N/A | 23.6 ms | N/A |
| 🆕 |
output_transforms[10] |
N/A | 23.6 ms | N/A |
| 🆕 |
output_transforms[100000] |
N/A | 217.6 ms | N/A |
Comparing feat/output-handler (73154c4) with master (ebdd099)
Coverage Report for CI Build 38028300055Coverage increased (+0.4%) to 74.87%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
ptondereau
force-pushed
the
feat/output-handler
branch
from
October 9, 2026 22:14
a7d2aa1 to
275ed11
Compare
ptondereau
force-pushed
the
feat/output-handler
branch
from
October 10, 2026 05:40
275ed11 to
73154c4
Compare
ptondereau
marked this pull request as ready for review
October 10, 2026 06:04
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
zend::start_output_handler, a safe wrapper aroundphp_output_handler_create_internal(same API from 8.1 to 8.5) where the closure borrows the buffered bytes without a copy and returns aCow, and a borrowed start of the input goes back to the engine without a copy. The engine owns every output buffer it gets, so neither a header callback that runs the handler again nor a fatal error swallowed in the closure can leave it with a freed pointer.Checklist