Repository navigation
fix(macros): run the ModuleBuilder startup function under #[php_module] - #811
Merged
Merged
Conversation
Merging this PR will not alter performance
|
Coverage Report for CI Build 37997613183Coverage remained the same at 74.503%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
ptondereau
force-pushed
the
fix/module-builder-startup-function
branch
from
October 9, 2026 22:09
f7b479b to
8c8d93e
Compare
ptondereau
marked this pull request as ready for review
October 10, 2026 04:38
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#[php_module]set its own startup function after the user's builder code, so a function given toModuleBuilder::startup_functionnever ran, and the generated MINIT now calls it after the#[php(startup)]one. The guide also documented#[php_module(startup = ...)]while the macro reads#[php(startup = ...)].Checklist