Repository navigation
fix(observer): register the hooks again when the SAPI restarts the module - #809
Merged
Merged
Conversation
Coverage Report for CI Build 37858687091Warning No base build found for commit Coverage: 74.488%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
ptondereau
force-pushed
the
fix/observer-module-restart
branch
from
October 8, 2026 23:18
3726b81 to
1a8fee0
Compare
ptondereau
marked this pull request as ready for review
October 9, 2026 06:28
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #807: since a SAPI restart resets the engine's observer lists and exception hook, the fcall, error and exception observers now register their hooks again on every MINIT with the same instance, instead of going silent after the first restart. It also restores
RefUnwindSafeonClassMetadata, lost in #807 and the reason #810 plans 0.17.0, uses release/acquire ordering for the class entry pointer and documents that class entries are valid only until the module shuts down.Checklist