Repository navigation
fix(macro)!: consistent PHP names and deterministic output - #791
Merged
Merged
Conversation
Coverage Report for CI Build 35777977215Coverage increased (+0.5%) to 70.142%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#[php_impl_interface]now registers each method under the name#[php_interface]declared, rename options follow one set of rules (change_cases_case, nonamewithchange_case), and generated method flags come out in a fixed order.Two items that get the same PHP name are a compile error inside one block and a registration error across blocks, instead of PHP silently dropping methods, replacing a class or stopping at startup.
Checklist