Skip to content

fix(macro)!: consistent PHP names and deterministic output - #791

Merged
ptondereau merged 6 commits into
masterfrom
fix/dx1c-rename-consistency
Sep 22, 2026
Merged

ptondereau merged 6 commits into
masterfrom
fix/dx1c-rename-consistency

Conversation

@ptondereau

Copy link
Copy Markdown
Member

Description

#[php_impl_interface] now registers each method under the name #[php_interface] declared, rename options follow one set of rules (change_cases_case, no name with change_case), and generated method flags come out in a fixed order.

Two items that get the same PHP name are a compile error inside one block and a registration error across blocks, instead of PHP silently dropping methods, replacing a class or stopping at startup.

Checklist

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 35777977215

Coverage increased (+0.5%) to 70.142%

Details

  • Coverage increased (+0.5%) from the base build.
  • Patch coverage: 12 uncovered changes across 6 files (311 of 323 lines covered, 96.28%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/builders/enum_builder.rs 31 27 87.1%
crates/macros/src/enum_.rs 8 6 75.0%
crates/macros/src/impl_.rs 29 27 93.1%
crates/macros/src/interface.rs 47 45 95.74%
crates/macros/src/impl_interface.rs 7 6 85.71%
src/builders/class.rs 102 101 99.02%
Total (9 files) 323 311 96.28%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 14147
Covered Lines: 9923
Line Coverage: 70.14%
Coverage Strength: 58.68 hits per line

💛 - Coveralls

@codspeed

codspeed Bot commented Sep 22, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 30 untouched benchmarks


Comparing fix/dx1c-rename-consistency (3fa459a) with master (b8978a1)

Open in CodSpeed

@ptondereau
ptondereau marked this pull request as ready for review September 22, 2026 20:30
@ptondereau
ptondereau merged commit 5467342 into master Sep 22, 2026
72 checks passed
@ptondereau
ptondereau deleted the fix/dx1c-rename-consistency branch September 22, 2026 20:30
@Xenira Xenira mentioned this pull request Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants