Skip to content

Update k8s-manifest.prod.yaml - #127

Merged
evereq merged 1 commit into
stagefrom
develop
Nov 4, 2025
Merged

evereq merged 1 commit into
stagefrom
develop

Conversation

@evereq

@evereq evereq commented Nov 4, 2025

Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issues.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Previous screenshots

Please add here videos or images of the previous status

Current screenshots

Please add here videos or images of the current (new) status

Signed-off-by: Ruslan Konviser <evereq@gmail.com>
@evereq
evereq merged commit 858be1f into stage Nov 4, 2025
9 checks passed

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Scaled production deployments from 1 to 2 replicas for both the API and portal services to improve availability and load distribution.

  • Increased ever-rec-api-prod deployment replicas from 1 to 2
  • Increased ever-rec-portal-prod deployment replicas from 2 to 2
  • Services and Ingress configurations remain unchanged, supporting automatic load balancing

Confidence Score: 4/5

  • Safe to merge with minor consideration for infrastructure capacity
  • The changes are straightforward and low-risk: simply increasing replica counts. However, the score is 4 instead of 5 because: (1) No resource limits/requests are defined in the deployments, which could lead to resource contention with 2x pods, and (2) the PR template checklist is completely unfilled, violating custom instruction 90653f25-bd57-4517-ae57-772fe2013d9c
  • Verify cluster has sufficient CPU/memory capacity for doubled pod count

Important Files Changed

File Analysis

Filename Score Overview
.deploy/k8s/k8s-manifest.prod.yaml 4/5 Increased replica count from 1 to 2 for both API and portal deployments to improve availability

Sequence Diagram

sequenceDiagram
    participant K8s as Kubernetes Cluster
    participant Deploy as Deployment Controller
    participant API1 as API Pod 1
    participant API2 as API Pod 2
    participant Portal1 as Portal Pod 1
    participant Portal2 as Portal Pod 2
    participant Svc as Service Load Balancer
    participant Ingress as Ingress Controller
    
    Note over K8s,Deploy: Scale Up Operation (1→2 replicas)
    Deploy->>K8s: Create new API pod (replica 2)
    K8s->>API2: Start container
    API2->>API2: Initialize with env vars
    Deploy->>K8s: Create new Portal pod (replica 2)
    K8s->>Portal2: Start container
    Portal2->>Portal2: Initialize with env vars
    
    Note over Svc: Load balancing across pods
    Ingress->>Svc: Request to api.rec.so
    Svc->>API1: Route request (round-robin)
    Ingress->>Svc: Request to api.rec.so
    Svc->>API2: Route request (round-robin)
    
    Ingress->>Svc: Request to app.rec.so
    Svc->>Portal1: Route request (round-robin)
    Ingress->>Svc: Request to app.rec.so
    Svc->>Portal2: Route request (round-robin)
Loading

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

name: ever-rec-api-prod
spec:
replicas: 1
replicas: 2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding resource limits and requests for CPU/memory when doubling replicas to prevent cluster resource contention.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .deploy/k8s/k8s-manifest.prod.yaml
Line: 35:35

Comment:
**style:** Consider adding resource limits and requests for CPU/memory when doubling replicas to prevent cluster resource contention.

How can I resolve this? If you propose a fix, please make it concise.

This branch was previously deployed

1 inactive deployment
dev — 69ce5277 Deployed Nov 4, 2025 by evereq via deploy-demo #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant