Skip to content

Two checklist rows share one ID, and the consistency test cannot see it #3639

Description

@axiosdevs

docs/writing_tests/checklist_templates/eip_testing_checklist_template.md lines 821-822 use the same ID for two different requirements:

821 | `transaction_type/test/intrinsic_validity/data_floor_above_intrinsic_gas_cost` | Invalid if data_floor_cost(len(tx.data)) > tx.intrinsic_gas_cost and tx.gas_limit == tx.intrinsic_gas_cost
822 | `transaction_type/test/intrinsic_validity/data_floor_above_intrinsic_gas_cost` | Valid if data_floor_cost(len(tx.data)) > tx.intrinsic_gas_cost and tx.gas_limit == data_floor_cost(len(tx.data))

A test that marks that ID covers both rows, so one of the two requirements can read as covered while nothing exercises it.

extract_markdown_ids in packages/testing/src/execution_testing/checklists/tests/test_checklist_template_consistency.py:20 collects into a set, so test_checklist_template_consistency compares set differences only and a repeated ID is invisible to it by construction. This is the single duplicate among 269 IDs on forks/amsterdam (faf6637).

Happy to open a PR if wanted

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions