Use ephemeral port for testing - #71
Open
ishitatsuyuki wants to merge 2 commits into
Open
Conversation
jankeromnes
approved these changes
Apr 27, 2018
jankeromnes
left a comment
jankeromnes
left a comment
Collaborator
There was a problem hiding this comment.
Very cool trick, thanks!
Looks good to me.
jankeromnes
reviewed
Apr 27, 2018
|
|
||
| // FIXME: is there a good way to make a server get a port for testing? | ||
| var server; | ||
| var portNumber = 8000; |
Collaborator
There was a problem hiding this comment.
Nit: Please keep a var portNumber; or var portNumber = 0; here instead of relying on the portNumber = ... above to create an accidental global.
jankeromnes
reviewed
Apr 27, 2018
| portNumber++; | ||
| serverStartDomain.run(startServer); | ||
| } else { | ||
| throw err; |
Collaborator
There was a problem hiding this comment.
Are you certain that serverStartDomain errors are automatically thrown when you don't have a .on('error', listener)?
Contributor
Author
There was a problem hiding this comment.
No it isn't. Can we just remove the domain wrapper here?
Owner
There was a problem hiding this comment.
Wasn't the domain's only purpose to handle EADDRINUSE? It seems like we can remove the domain altogether.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, fix the issue where passing 0 to camp.start doesn't work.