Skip to content

Upload Credo SARIF when Credo finds issues - #567

Merged
maennchen merged 1 commit into
mainfrom
fix-credo-sarif-upload
Nov 4, 2026
Merged

maennchen merged 1 commit into
mainfrom
fix-credo-sarif-upload

Conversation

@maennchen

Copy link
Copy Markdown
Member

Credo exits non-zero when it finds issues. The job then skipped the SARIF upload, so findings never reached code scanning.

The upload step now runs when the Credo step ran, also if Credo failed. It does not run if the job was cancelled or an earlier step failed, because then no results.sarif exists. The job still fails on Credo findings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@maennchen
maennchen merged commit a6c128d into main Nov 4, 2026
28 checks passed
@maennchen
maennchen deleted the fix-credo-sarif-upload branch November 4, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant