Repository navigation
feat: JAVA_HOME support - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds environment activation support to the Java (Eclipse Adoptium OpenJDK) proto plugin so that JAVA_HOME is set when the tool is activated.
Changes:
- Implement
activate_environmentplugin function to exportJAVA_HOME(with macOS-specificContents/Homehandling). - Add an integration test ensuring
JAVA_HOMEis provided on activation. - Update Rust toolchain and bump (dev)dependencies to versions that support the new activation API.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/proto.rs |
Adds activate_environment to return JAVA_HOME based on platform. |
tests/environment_test.rs |
Adds a test covering environment activation output. |
Cargo.toml |
Updates proto_pdk / test utils and other dependency versions. |
rust-toolchain.toml |
Bumps the Rust toolchain channel used by the repo. |
Cargo.lock |
Refreshes the lockfile to match dependency/toolchain updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3