Skip to content

feat: JAVA_HOME support - #5

Merged
eplightning merged 2 commits into
mainfrom
java-home-support
Apr 25, 2026
Merged

eplightning merged 2 commits into
mainfrom
java-home-support

Conversation

@eplightning

@eplightning eplightning commented Apr 25, 2026 •

Copy link
Copy Markdown
Owner

Closes #3

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds environment activation support to the Java (Eclipse Adoptium OpenJDK) proto plugin so that JAVA_HOME is set when the tool is activated.

Changes:

  • Implement activate_environment plugin function to export JAVA_HOME (with macOS-specific Contents/Home handling).
  • Add an integration test ensuring JAVA_HOME is provided on activation.
  • Update Rust toolchain and bump (dev)dependencies to versions that support the new activation API.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/proto.rs Adds activate_environment to return JAVA_HOME based on platform.
tests/environment_test.rs Adds a test covering environment activation output.
Cargo.toml Updates proto_pdk / test utils and other dependency versions.
rust-toolchain.toml Bumps the Rust toolchain channel used by the repo.
Cargo.lock Refreshes the lockfile to match dependency/toolchain updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/proto.rs Resolved
Comment thread tests/environment_test.rs Resolved
@eplightning
eplightning merged commit 6ce7bcb into main Apr 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JAVA_HOME is not set

2 participants