Repository navigation
Conversation
The campaign did use `rec.index` for updating the metadata. This can cause issues for recommenders that might not preserve the original index order.
Scienfitz
requested changes
Oct 17, 2026
Collaborator
There was a problem hiding this comment.
Are you sure this is constructed in the best possible manner?
- The fuzzy row match is not 100% free from a computaitional perspective, its application should thus only happen if needed. This PR as is adds cost for all paths
- all existing recommenders have the index correct by construction, applying a fuzzy row match here has no added benefit for them as its not needed and just adds cost
- I understand its needed for the LLM recommender. But since thats the only one, why are you not using the fuzzy row match within that recommender to set the correct index of the recommendations? This would result in the exact same behavior but adds no cost for all other paths
Collaborator
Author
There was a problem hiding this comment.
It seems like this is even incorrect and I need to rethink this in general, but looking at it now, I agree that this should be part of the LLMRecommender. Closing this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The campaign currently uses
rec.indexfor updating the metadata. This PR changes this behavior by usingfuzzy_row_matchinstead of explicitly matching againstrec.index.Using
rec.indexcan cause issues for recommenders that change or do not preserve the index. This has been observed during the development of theLLMRecommenderin #855