Repository navigation
Use lychee for docbuilding - #898
Merged
Merged
Conversation
AVHopp
commented
Aug 18, 2026
AVHopp
commented
Aug 18, 2026
AVHopp
commented
Aug 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures BayBE’s documentation CI so external link checking is run as a dedicated step/job instead of being embedded in the documentation build script, and it tunes Sphinx linkcheck settings to make the new gating behavior more reliable.
Changes:
- Adds a dedicated
linkchecktox environment and wires it into GitHub Actions (including a separate CI job). - Removes linkcheck logic/flags from
docs/scripts/build_documentation.pyand enables parallel Sphinx builds. - Configures Sphinx linkcheck behavior (ignore patterns + timeout/retries) for more stable CI runs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tox.ini |
Adds testenv:linkcheck and updates docs-quickbuild to match the new separation. |
docs/scripts/check_links.py |
Updates linkcheck utility and adds parallel build flag. |
docs/scripts/build_documentation.py |
Removes linkcheck flag/logic and enables parallel Sphinx HTML build. |
docs/conf.py |
Adds linkcheck ignore/timeout/retry settings to reduce flaky failures. |
CHANGELOG.md |
Notes the new documentation linkcheck job. |
.github/workflows/docs.yml |
Runs linkcheck explicitly before building/publishing docs. |
.github/workflows/ci.yml |
Introduces a dedicated linkcheck job and makes docs build depend on it. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AVHopp
force-pushed
the
docs/separate_linkcheck_new
branch
from
August 19, 2026 07:08
51ac6a5 to
be0aaa7
Compare
AVHopp
force-pushed
the
docs/separate_linkcheck_new
branch
from
August 19, 2026 07:12
be0aaa7 to
297738c
Compare
AVHopp
commented
Aug 19, 2026
AVHopp
marked this pull request as draft
August 20, 2026 08:56
AVHopp
force-pushed
the
docs/separate_linkcheck_new
branch
from
August 20, 2026 09:38
3e48b15 to
297738c
Compare
AVHopp
force-pushed
the
docs/separate_linkcheck_new
branch
from
August 20, 2026 09:49
297738c to
24125fa
Compare
AVHopp
changed the base branch from
docs/refactor-apidoc_new
to
docs/parallelize_example_execution
August 20, 2026 10:45
AVHopp
marked this pull request as ready for review
August 20, 2026 10:46
AVHopp
marked this pull request as draft
August 20, 2026 10:49
AVHopp
force-pushed
the
docs/separate_linkcheck_new
branch
from
August 20, 2026 11:01
56edeec to
c4068b9
Compare
AVHopp
marked this pull request as ready for review
August 20, 2026 11:02
AVHopp
force-pushed
the
docs/separate_linkcheck_new
branch
from
August 20, 2026 11:18
c4068b9 to
9e3a794
Compare
AVHopp
marked this pull request as draft
August 20, 2026 13:32
AVHopp
force-pushed
the
docs/separate_linkcheck_new
branch
2 times, most recently
from
August 31, 2026 08:13
fa70d27 to
14e9af8
Compare
AVHopp
force-pushed
the
docs/separate_linkcheck_new
branch
from
September 11, 2026 10:22
22d45fe to
4622a11
Compare
AVHopp
force-pushed
the
docs/separate_linkcheck_new
branch
from
September 11, 2026 11:05
4622a11 to
98fd9e4
Compare
lychee for docbuilding
AVHopp
force-pushed
the
docs/separate_linkcheck_new
branch
3 times, most recently
from
September 11, 2026 12:33
8eaa054 to
b24fd59
Compare
Scienfitz
marked this pull request as ready for review
September 11, 2026 13:27
Scienfitz
reviewed
Sep 11, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Three moderate review findings remain unresolved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
.github/workflows/ci.yml:90
- Moving external-link checking out of
build_documentation.pyalso changes the separate.github/workflows/docs.ymlpublish path: it still runs the build script onmainpushes, releases, and manual runs, but it has no lychee step or dependency. Theneeds: [lint, lychee]here cannot gate that separate workflow, so documentation can still be published without external-link validation; add lychee to the publishing workflow or otherwise make publication depend on the check if that path is in scope.
build-docs:
name: "Build Docs"
runs-on: ubuntu-latest
needs: [lint, lychee]
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Lite
AVHopp
commented
Sep 11, 2026
Scienfitz
approved these changes
Sep 23, 2026
AdrianSosic
approved these changes
Oct 8, 2026
Checking of external links is no longer handled by the `linkcheck` builder. The `dummy ` builder is used instead, which does not check external links but still checks internal links.
Those helpers and tools were previously used for checking links, but now they focus on verifying cross-references instead.
AVHopp
force-pushed
the
docs/separate_linkcheck_new
branch
from
October 8, 2026 14:37
275b434 to
c5ac4b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR separates the linkcheck job from the actual doc building. It does so by creating a new dedicated job for it in the CI and re-organizing the code.
External link checking
linkcheckbuilder with lychee for external URL validationbaybe/,docs/,examples/, and top-level markdown fileslychee.toml(migrated fromlinkcheck_ignoreindocs/conf.py)linkcheck_ignorefromdocs/conf.pyCross-reference checking
Naming cleanup
check_linkstochange_crossrefsCI changes
Misc
sphinx). At the end of that job there is also a short summary (see screenshots)lycheefor internal links but since thesphinx htmlbuild already does this, there is no further speed-up that we can gain here.Stack created with GitHub Stacks CLI • Give Feedback 💬