Invalid versions#172
Open
tcjr wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for upgrade-guide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two small UI improvements regarding invalid version combinations.
Firstly, when an invalid combination is chosen, the button is disabled but the
EsButtoncomponent does not change the look at all. This PR grays out buttons when they are disabled. It also puts the text into a well to make it slightly more prominent.Secondly, any options that are invalid for the To or From selectors are given an "invalid" treatment to discourage the user from selecting those versions. For example, if the From version is
4.5, then any version before and including4.5are grayed out in the To selector. Similarly, if the To version is set to5.5, then anything after5.5is grayed out in the From selector."Grayed out" here includes a strikethrough, but I'm not fully sold on it.
Here's what the To selector looks like when the From is already set to
4.5.