Skip to content

fix: ignore compile_env trace events #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doorgan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ignore compile_env trace events #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/elixir_sense/core/compiler.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@ defmodule ElixirSense.Core.Compiler do
|> State.add_call_to_line({as, nil, nil}, meta, :alias_expansion_as)
|> State.add_call_to_line({alias, nil, nil}, meta, :alias_expansion)

{:compile_env, _app, _path, _return} ->
# emitted by Application.compile_env/4 when a macro such as dbg/2 reads config
acc

_ ->
Logger.warning("Unhandled trace event: #{inspect(event)}")
acc
Expand Down
14 changes: 14 additions & 0 deletions test/elixir_sense/core/metadata_builder_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7257,6 +7257,20 @@ defmodule ElixirSense.Core.MetadataBuilderTest do
assert %{{SomeMod, :my_fun, 0} => _} = state.mods_funs_to_positions
end

test "does not warn on compile_env trace events" do
log =
ExUnit.CaptureLog.capture_log([level: :warning], fn ->
"""
defmodule SomeMod do
def fun(a), do: dbg(a)
end
"""
|> string_to_state
end)

refute log =~ "Unhandled trace event"
end

defmodule SomeCompiledMod do
defmacro go do
quote do
Expand Down