Repository navigation
Bump toxic2 - #349
Merged
Merged
Bump toxic2#349
Conversation
Picks up lukaszsamson/toxic2#1, which makes the lowerer treat names over the 255-character atom limit as unconvertible atoms instead of raising SystemLimitError, so ElixirSense.Core.Parser.parse_string no longer crashes on files containing such an alias. Also includes the toxic2 grammar-gap and performance fixes since c47c911.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps toxic2 from
c47c911to79e583a.The main reason is lukaszsamson/toxic2#1. A file containing an alias segment (or other name) over the 255-character atom limit made
ElixirSense.Core.Parser.parse_string/4raise, so every request on that file crashed:Such names are now lowered like any other unconvertible atom (an
__error__node plus a:nonexistent_atomdiagnostic).The range also brings in the toxic2 grammar-gap fixes (the P0–P4 and OX/KIMI audit findings) and the lexer/parser/lowerer performance work. That is 56 commits, about 2.7k lines changed in
lib/.Verified locally on Elixir 1.20.4 / OTP 29: the full suite gives 2313 passed (9 doctests, 5 properties, 2299 tests), the same as master with the old pin, and the long-alias repro no longer raises.