Repository navigation
Fix list operators type inference test on Elixir 1.20.3+ - #347
Merged
Merged
Conversation
Elixir 1.20.3 (elixir-lang/elixir@f894bc4) infers the result of :erlang.++ from its arguments instead of the static signature, so native typing of `[a] ++ [b]` is now a proper non-empty list rather than the call thunk fallback. Gate the native expectation on the Elixir version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on master fails on every Elixir 1.20.x job (it has since 1.20.3 was released) with one test:
Elixir 1.20.3 (elixir-lang/elixir@f894bc4, "Provide proper signature for ++") added a
remote_apply(:erlang, :++, ...)rule. It types the result from the arguments, so[a] ++ [b]is now a proper non-empty list instead of the improper-tail static signature. That result is more precise and correct. This PR gates the native expectation on>= 1.20.3and leaves the older expectation for 1.19 – 1.20.2.Verified locally:
type_inference_test.exspasses on 1.20.4/OTP 29 and 1.19.4/OTP 28.