Tweak: Remove notifications legacy code - #232
Open
KingYes wants to merge 3 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
Removing dormant notifications subsystem—class includes, property initialization, AJAX handler, UI fields, and associated JavaScript. Cleaning up legacy code path.
2. What Changed (Where)
aryo-activity-log.php: Removedclass-aal-notifications.phpinclude and$notificationsproperty initializationclass-aal-settings.php: Stripped notifications tab, AJAX handler, settings fields, script enqueue, and UI rendering (~130 lines)assets/js/settings.js: Deleted entire file (~124 lines of notification rule builder logic)3. How It Works
Plugin previously supported email notifications with dynamic rule building (user/action-type/action-value conditions). The AJAX endpoint
aal_get_propertiespopulated dropdowns based on selected categories. This entire subsystem is now removed—no notifications instantiation, no settings UI, no client-side rule management.4. Risks
None identified. Assumes notifications feature was unused or superseded. If any active installs depend on
AAL_Notificationsclass or the settings UI, they'll silently lose functionality. Mitigation: version bump with deprecation notice in prior release recommended, though not in scope here.Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how