Tweak: Added more escaping - #231
Open
KingYes wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
Security audit: systematically escaping all user-facing output and sanitizing $_REQUEST/($_SERVER inputs across the codebase. Promotes EscapeOutput violations from warnings to CI errors.
2. What Changed (Where)
aryo-activity-log.phpclass-aal-activity-log-list-table.phpclass-aal-admin-ui.phpclass-aal-api.phpclass-aal-settings.phpclass-aal-maintenance.php,class-aal-notifications.phpabstract-class-aal-notification-base.phpruleset.xml3. How It Works
Follows WordPress escaping hierarchy: context-specific functions (esc_html, esc_attr, esc_url, esc_js) for output; sanitize_* + wp_unslash for input. AJAX handlers validated with check_ajax_referer + permission checks. Refactored sprintf+echo patterns to printf with proper escaping to prevent double-escaping.
4. Risks
Low risk—primarily defensive hardening. Verify AJAX nonce flow (aalSettings.nonce injection in settings.js) matches handler expectations. Check that escaped output doesn't break any dynamic JS selectors or data attributes in filter dropdowns.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how