event-app: improve first pwa push notification prompt - #139
Merged
Merged
Conversation
…nstead of first launch, and turns session reminders on
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Deploy Preview for devcon-event-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…ridgeLink for sign-in link generation, improving iOS Safari handoff and session persistence; update related logic for QR code generation and link handling
…n components for clarity; enhance onboarding messaging in PushOnboardingSheet to improve user experience
didierkrux
requested changes
Sep 29, 2026
didierkrux
left a comment
Member
There was a problem hiding this comment.
I did 2 commits on this branch since your review request:
- Safari hop on iOS non-Safari browsers (pre-existing bug, not from this PR): the "Open in Safari" tap minted the bridge token before navigating, so on a cold function the gesture expired and iOS blocked the handoff. The link is now minted when the install modal opens (shared
mintBridgeLink, also used by the desktop QR) and the tap navigates synchronously. - Sign-in copy: the sheet, the sign-in page and the Home banner said notifications need the ticket email. They now lead with the ticket email and say any email works for Interests and notifications.
Four suggestions (see what makes sense to implement):
- Also ask when push is on but reminders are off. Anyone who tapped the Home "Turn on notifications" card (announcements only) never sees the reminders pitch. Open the sheet on the third star in that state too, with the primary calling
setPref("reminders", true)(a PATCH, no permission prompt). - Don't open mid-burst. Wait until a few seconds pass with no star tap before sliding up, so a fourth tap doesn't land on the scrim or "Not now" and burn the one ask.
- "Not now" shouldn't mean never. After it, the user is never asked again. Rather than another modal, a quiet standing row in the My Interests view: one line, "Get a nudge 10 minutes before each of these", linking to the notification settings, shown while reminders are off. It sits where the value is obvious, doesn't interrupt, and never expires, so "Not now" becomes "not yet".
- Done title: "Notifications are on" rather than "Reminders are on", since announcements were switched on as well.
…, waits for star taps to pause, and titles Done "Notifications are on"; My Interests gains a standing "Get a nudge 10 mins before each interest" row into the settings modal; remove the unused intro-splash signal
Collaborator
Author
Ask for notifications when users care, not on first launchThe one-time notifications sheet no longer opens at first launch. It opens once, in the installed app, when someone adds their third session to their interests. What changed
|
Member
|
Thanks for the changes Scott. I merged main to the branch, resolved all the conflicts and checked for any regression. |
Collaborator
Author
|
No problem Didier. Thanks for resolving conflicts 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask for notifications when users care, not on first launch
The one-time "Turn on notifications" sheet used to open as soon as someone first launched the installed app, before they knew what the app does. It now opens once, when they add their third session to their interests. By then they've shown they care about the schedule, which is exactly what session reminders are for.
What changed
Testing
The sheet can't open under
pnpm dev(it needs the installed app), so test it on a deploy preview.Tip: "Reset nudges" in EF internal tools (My Devcon) clears the "already shown" flag.