Repository navigation
chore(agents): add mattpocock's tdd skill - #2051
devin-ai-integration[bot] wants to merge 7 commits into
Conversation
Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
TASTE.md review: compliant. 0 violations. The PR changes only agent tooling (.agents/skills/tdd/*, the .claude/skills symlink, one line in CLAUDE.md) and touches nothing in packages/js-sdk or packages/python-sdk, so none of the SDK API-surface rules (T-1 to T-74) apply.
Package ArtifactsBuilt from 50e9e60. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-dockerfile-utils-0.1.2-devin-1793236108-tdd-skill.0.tgz ./e2b-2.62.1-devin-1793236108-tdd-skill.0.tgzCLI ( npm install ./e2b-cli-2.23.1-devin-1793236108-tdd-skill.0.tgzCode Interpreter JS SDK ( npm install ./e2b-code-interpreter-2.9.1-devin-1793236108-tdd-skill.0.tgzDesktop JS SDK ( npm install ./e2b-desktop-2.5.1-devin-1793236108-tdd-skill.0.tgzPython SDK ( pip install ./e2b_dockerfile_utils-0.1.1+devin.1793236108.tdd.skill-py3-none-any.whl ./e2b-2.62.0+devin.1793236108.tdd.skill-py3-none-any.whlCode Interpreter Python SDK ( pip install ./e2b_code_interpreter-2.11.6+devin.1793236108.tdd.skill-py3-none-any.whlDesktop Python SDK ( pip install ./e2b_desktop-2.7.2+devin.1793236108.tdd.skill-py3-none-any.whl |
Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
Co-Authored-By: mish@e2b.dev <mish@e2b.dev>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Summary
Vendors mattpocock/skills
tddunchanged intoskills/tdd/(SKILL.md,tests.md,mocking.md,agents/openai.yaml), next toskills/stripe-projects, plus its MITLICENSE. It covers testing at public seams, mocking only at system boundaries, avoiding tautological asserts, and red → green in vertical slices.CLAUDE.md(whichAGENTS.mdsymlinks to) gains one line: follow the TDD skill inskills/tdd/SKILL.mdwhen writing or fixing tests. Agents reach the skill through that pointer; there is no.claude/skillssymlink.Since
npx skills add e2b-dev/E2Bscansskills/, users installing E2B's skills will also be offeredtdd.The files are a verbatim copy, so
SKILL.mdstill mentionsGLOSSARY.md/ADRs and thecodebase-design/code-reviewskills, none of which exist in this repo. Re-sync from upstream by re-copying at a newer commit.Linear: SDK-411 (related: SDK-410)
Link to Devin session: https://app.devin.ai/sessions/c0621a9c6481454bbaced63fd96cb897
Open in Devin Desktop: https://app.devin.ai/desktop/session/c0621a9c6481454bbaced63fd96cb897?variant=devin
Requested by: @mishushakov