Skip to content

fix(prefer-timer-args): check UpdateExpressions & TemplateLiterals #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
43081j merged 1 commit into from
Sep 17, 2026
Merged

fix(prefer-timer-args): check UpdateExpressions & TemplateLiterals #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/rules/prefer-timer-args.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,16 @@ ruleTester.run('prefer-timer-args', preferTimerArgs, {
'setTimeout(() => fn({key: getData()}), 100)',
'setTimeout(fn.bind(null, getData()), 100)',

// Unsafe transformations - arguments mutate state
'setTimeout(() => fn(i++), 100)',
'setTimeout(() => fn(--i), 100)',
'setTimeout(() => fn(delete obj.key), 100)',
'setTimeout(fn.bind(null, i++), 100)',

// Unsafe transformations - template literals containing calls
'setTimeout(() => fn(`${getData()}`), 100)',
'setTimeout(() => fn(`${i++}`), 100)',

// window.setTimeout examples
'window.setTimeout(doSomething, 100)',
'window.setTimeout(() => { doSomething(a); }, 100)',
Expand Down
8 changes: 6 additions & 2 deletions src/rules/prefer-timer-args.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,11 @@ function isSafeArgument(arg: Expression | SpreadElement): boolean {
switch (arg.type) {
case 'Identifier':
case 'Literal':
case 'TemplateLiteral':
return true;

case 'TemplateLiteral':
return arg.expressions.every(isSafeArgument);

case 'MemberExpression':
if (
arg.object.type === 'Super' ||
Expand Down Expand Up @@ -76,7 +78,9 @@ function isSafeArgument(arg: Expression | SpreadElement): boolean {
});

case 'UnaryExpression':
case 'UpdateExpression':
if (arg.operator === 'delete') {
return false;
}
return isSafeArgument(arg.argument);

case 'BinaryExpression':
Expand Down