Repository navigation
Shorten ECMWF HTTP 404 fallback warnings - #1180
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECMWF mirror fallback warnings repeat the 404 response XML and multiline debug representation for each missing object. Keep these warnings at WARNING, but shorten messages containing
404 Not Foundto the source, exception class, status and the first HTTP(S) URL when present.Classification uses a simple substring check. Messages without
404 Not Foundretain their full detail. Source ordering, retry behavior, warning count, and re-raising the original final exception are unchanged. This shared helper covers IFS ENS 15-day, AIFS ENS and AIFS single.Validation:
uv run pytest -m "not slow" tests/ecmwf— 485 passed; real obstore whole-object/range 404s, unfamiliar 404 formats with and without URLs, non-404 logging and original final-exception identity. Repository-wide Ruff formatting/lint and ty checks passed.