Skip to content

CoW Protocol: Misleading dex_swaps Evaluation #9731

Description

@bh2smith

In the early days (before many exotic interactions were happening) this case statement was a fairly-accurate count of the number of dex swaps in a batch. However now we are seeing many other function selectors occurring in settlement interactions. Its probably too difficult to capture/classify dex swaps

Recommend deprecating this field.

sum(
case
when selector != 0x2e1a7d4d -- unwrap
and selector != 0x095ea7b3 -- approval
then 1
else 0
end
) as dex_swaps,

(also copied over through all networks where cow is deployed).

cc @harisang, @fhenneke

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions