Skip to content

remove dependency on six#318

Closed
a-detiste wants to merge 2 commits into
dropbox:mainfrom
a-detiste:main
Closed

remove dependency on six#318
a-detiste wants to merge 2 commits into
dropbox:mainfrom
a-detiste:main

Conversation

@a-detiste

Copy link
Copy Markdown

Your project states "Stone requires Python 3.", so six can be dropped.

https://wiki.debian.org/Python3-six-removal

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • [?] Do the tests pass?

@CLAassistant

CLAassistant commented Jan 24, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@greg-db

greg-db commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

Thanks for putting this together! I'll ask the team to review this.

@a-detiste

Copy link
Copy Markdown
Author

It'more about tearing appart than putting together :-)

@hugovk

hugovk commented Oct 23, 2024

Copy link
Copy Markdown

This PR has a merge conflict.

@a-detiste

Copy link
Copy Markdown
Author

This PR has a merge conflict.

fixed

@AndreyVMarkelov

Copy link
Copy Markdown
Contributor

Thanks for this, @a-detiste — and apologies it sat open so long. The six removal has now landed on main via #365, which dropped six from requirements.txt and replaced all usages across the obj_c, swift, and python_rsrc backends (using an ensure_str helper to preserve the bytes-decoding semantics), simplified _strftime, and modernized the Python floor/CI along the way. main now has zero six references.

Your PR informed that direction, so thank you for it. Since the goal is fully covered on main and this branch is now several commits behind (and would conflict), I'm closing this as superseded by #365. Really appreciate the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants