Remove build-time Java resources from APKs - #12792
Open
simonrozsival wants to merge 2 commits into
Open
simonrozsival wants to merge 2 commits into
simonrozsival wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
AAB archive paths and include overrides need focused test coverage.
Get a fresh assessment by requesting another Copilot review.
Review tier: Lite
Findings: 1
Open (1)
What changed in this PR
This PR removes build-time-only Java archive entries from APK/AAB packages while preserving runtime resources and explicit inclusion overrides.
Changes:
- Filters nested JARs, KMP metadata, resource symbols, shrinker rules, and AAR metadata.
- Adds focused tests and documentation.
- Updates CoreCLR APK size baselines.
| File | Summary |
|---|---|
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Resources/Base/BuildReleaseArm64XFormsDotNet.CoreCLR.R8.apkdesc |
Updates APK size baseline. |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Resources/Base/BuildReleaseArm64XFormsDotNet.CoreCLR.apkdesc |
Updates APK size baseline. |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Resources/Base/BuildReleaseArm64SimpleDotNet.CoreCLR.R8.apkdesc |
Updates APK size baseline. |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Resources/Base/BuildReleaseArm64SimpleDotNet.CoreCLR.apkdesc |
Updates APK size baseline. |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/CollectJarContentFilesForArchiveTests.cs |
Tests filtering and explicit inclusion. |
src/Xamarin.Android.Build.Tasks/Tasks/CollectJarContentFilesForArchive.cs |
Implements build-time resource filtering. |
Documentation/docs-mobile/building-apps/build-items.md |
Documents packaging behavior. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java archives can contribute build-time-only resources to APK and AAB outputs, including nested
classes.jarfiles, Kotlin Multiplatform metadata, and embedded shrinker configuration.This change:
AndroidPackagingOptionsExcludeitems inAutoImport.in.propsR.txt, ProGuard/R8 rules, and AAR metadataMETA-INF/servicesand Kotlin builtinsTests:
./dotnet-local.sh test bin/TestRelease/net10.0/Xamarin.Android.Build.Tests.dll --filter "Name~CheckExcludedFilesAreMissing"PATH="$PWD/bin/Release/tools:$PATH" ./dotnet-local.sh test bin/TestRelease/net10.0/Xamarin.Android.Build.Tests.dll --filter "Name~BuildReleaseArm64"