[net] Make authentication modules trimmable - #12791
Open
simonrozsival wants to merge 1 commit into
Open
simonrozsival wants to merge 1 commit into
simonrozsival wants to merge 1 commit into
Conversation
Delay creation of the built-in Basic and Digest authentication modules until PreAuthenticationData is configured, allowing unused implementations to be removed by the linker. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add regression coverage for Basic/Digest authentication with configured pre-authentication data.
Get a fresh assessment by requesting another Copilot review.
Review tier: Lite
Findings: 1
Open (1)
What changed in this PR
Defers built-in Basic and Digest authentication module creation so unused implementations can be trimmed.
Changes:
- Lazily initializes authentication modules when pre-authentication is configured.
- Updates authentication lookup for uninitialized module storage.
| File | Summary |
|---|---|
src/Mono.Android/Xamarin.Android.Net/AndroidMessageHandler.cs |
Implements lazy authentication module initialization and lookup. Review noted missing Basic/Digest regression coverage. |
Comment on lines
+762
to
+766
| if (value != null && authModules == null) { | ||
| authModules = [ | ||
| new AuthModuleBasic (), | ||
| new AuthModuleDigest () | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PreAuthenticationDatais configured.AuthModuleBasic,AuthModuleDigest,AuthDigestSession, andAuthDigestHeaderParserto be trimmed from apps that do not use pre-authentication.Verification
make all.AndroidMessageHandlerwithoutPreAuthenticationDataand inspected the linkedMono.Android.dllto confirm the implementation types were removed.