Repository navigation
Refresh example certificate trust and build runtimes - #168
Merged
Merged
Conversation
saucow
approved these changes
Oct 23, 2026
saucow
left a comment
There was a problem hiding this comment.
Floors line up with the INC-663 guidance and upstream sources: certifi >=2026.10.19 (GHSA-6q48-6c7w-9gw2), Go 1.26.10, Debian ca-certificates 20250419+deb13u1 (trixie-security, DSA-6572-1) and 20250419~deb12u2 (bookworm-security), Alpine 20261020-r0. All Python/Go/Node Dockerfiles and the seven locks are covered; the Temurin examples are explicitly called out as out of scope in the new doc. CI is green. LGTM.
One nit before merging: the description still says "This is a draft pending the example CI/functional matrix", but the PR is not a draft and the matrix passed. Please refresh that paragraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example Python locks still pin certifi 2025.6.15, and the Go example builds with Go 1.24.1 and runs Alpine 3.19. Refresh the maintained Python/Go/Node build surfaces for the certificate distrust incident and document how users replace existing example images.
Validation:
uv lock --check --python 3.13 --offlinechecks andpoetry check --lockpass; independent TOML comparisons confirm every non-certifi package name/version is unchanged.Dockerfile.tools --target yamllintsuccessfully with a refreshed Python 3.13 base. The image reports ca-certificates 20250419+deb13u1 and pip 26.2.2; HTTPS positive control against PyPI returns 200 using system trust. A separate certifi 2026.10.19 positive control also returns 200.golang:1.26.10-alpine: Go 1.26.10 and installation of the required Alpine CA package succeed. The Node image manifest resolves; its runtime probe could not complete because the shared sandbox disk filled during layer extraction.git diff --checkpasses. Both commits have GitHub-verified SSH signatures.CI initially exposed a pre-existing LangGraph interpreter-selection issue: uv chose Python 3.15.1, while the unchanged ormsgpack/PyO3 dependency only supports through Python 3.14. Pin that check job to Python 3.13, matching its container runtime and the other Python CI jobs, so the checks execute against the supported example interpreter.
This is a draft pending the example CI/functional matrix and review of the runtime changes. The complete example build matrix is still running in CI; model/API journeys, compromised-chain fixture tests, and existing-installation replacements have not been completed. Temurin Java trust and third-party images remain explicitly unverified in the linked documentation; this PR does not close those incident work items. Refreshing the OS bundle alone does not verify Java or another embedded trust store.