Skip to content

Clean up SDK packs and manifests on uninstall - #347

Closed
agocke wants to merge 2 commits into
dn-vm:mainfrom
agocke:fix-uninstall-pack-cleanup
Closed

agocke wants to merge 2 commits into
dn-vm:mainfrom
agocke:fix-uninstall-pack-cleanup

Conversation

@agocke

@agocke agocke commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove SDK-owned reference packs when their runtime, ASP.NET, or Windows Desktop component is no longer used
  • record exact workload-manifest bands contributed by each SDK archive and safely prune unreferenced sdk-manifests directories
  • preserve workload-owned packs and bands referenced by workload installation metadata
  • add conservative manifest migration behavior for legacy SDK records with unknown ownership metadata
  • keep directory-specific uninstall and prune cleanup scoped to the matching SDK directory
  • refresh component and manifest ownership metadata on forced reinstall

Testing

  • dotnet test test/UnitTests/UnitTests.csproj --nologo (190 passed)
  • dotnet test test/IntegrationTests/IntegrationTests.csproj --nologo (18 passed, 1 skipped)

agocke added 2 commits August 8, 2026 16:30
Remove SDK-owned reference packs and safely prune workload manifests while preserving files shared by other SDKs or workloads.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ee57eeb5-f628-412d-8641-f5952aef0516
Deduplicate prune candidates and preserve channel state for valid SDK copies installed in other directories.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ee57eeb5-f628-412d-8641-f5952aef0516
@agocke

agocke commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator Author

Closing to split this into focused changes. The prune/stale-channel fix will be submitted separately; the uninstall cleanup work remains saved on its own branch.

@agocke agocke closed this Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant