Repository navigation
Fix SAX parser read of leaf_weights - #723
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mainline #723 +/- ##
============================================
+ Coverage 83.48% 84.16% +0.67%
============================================
Files 75 75
Lines 6855 6926 +71
Branches 560 560
============================================
+ Hits 5723 5829 +106
+ Misses 1132 1097 -35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Admin-merging this to unblock the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://github.com/dmlc/treelite/actions/runs/42772664827/job/129683852743:
Fix: When specifying a sub-range of
leaf_weights, useleaf_weights.begin() + Xinstead of&leaf_weights[X].The expression
&leaf_weights[X]is technically undefined whenX == leaf_weights.size(), even though we're only using this to indicate the end of the sub-range. The coverage test builds Treelite in the debug build, where the expression triggers an assertion error.