Skip to content

unsignedToTempString() code deduplication - #23603

Merged
thewilsonator merged 4 commits into
dlang:masterfrom
denizzzka:ddup_of_utots
Aug 15, 2026
Merged

unsignedToTempString() code deduplication#23603
thewilsonator merged 4 commits into
dlang:masterfrom
denizzzka:ddup_of_utots

Conversation

@denizzzka

@denizzzka denizzzka commented Aug 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

unsignedToTempString() code deduplication

I also added type template to avoid uint->ulong->uint conversion of argument

@denizzzka
denizzzka marked this pull request as draft August 15, 2026 06:32
@denizzzka
denizzzka marked this pull request as ready for review August 15, 2026 07:03
@denizzzka
denizzzka marked this pull request as draft August 15, 2026 07:45
@denizzzka
denizzzka force-pushed the ddup_of_utots branch 4 times, most recently from 679d9f9 to 0ecad2c Compare August 15, 2026 09:46
@denizzzka
denizzzka marked this pull request as ready for review August 15, 2026 10:07
@denizzzka

denizzzka commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

@thewilsonator
I changed the original idea to turning unsignedToTempString() into a template because in the future I plan also to add 1 or 2 template arguments to this function. And if I make two of them, I will have to add arguments to each.

Ready for review

Related: dlang/phobos#11082

@denizzzka

denizzzka commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

@thewilsonator

@thewilsonator
thewilsonator merged commit 33ccc90 into dlang:master Aug 15, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@denizzzka @thewilsonator