Skip to content

fix(username): prevent release errors when recording sync failures - #115

Merged
NotThatKindOfDrLiz merged 2 commits into
mainfrom
fix/local-d1-batch
Oct 4, 2026
Merged

NotThatKindOfDrLiz merged 2 commits into
mainfrom
fix/local-d1-batch

Conversation

@NotThatKindOfDrLiz

Copy link
Copy Markdown
Member

Username release preparation returned HTTP 500 in the real local Worker runtime when Fastly sync was unavailable. Recording the sync failure called D1’s batch method without its database receiver.

Call db.batch with the receiver intact and add a receiver-sensitive regression test. Username ownership and release semantics are unchanged; there is no visual change.

Validation: the regression failed before the fix; all 496 Worker tests and npm run typecheck pass afterward. The mobile local-stack integration will exercise the real D1 runtime against this commit.

Supports divinevideo/divine-mobile#7692 and divinevideo/divine-mobile#7691.

@NotThatKindOfDrLiz
NotThatKindOfDrLiz requested review from a team, dcadenas and realmeylisdev and removed request for a team October 3, 2026 23:47
@divine-roborev

divine-roborev Bot commented Oct 3, 2026

Copy link
Copy Markdown

roborev: Combined Review (ec9da72)

Verdict: No findings at or above high severity.


Reviewers: 2 done | Synthesis: opencode | Total: 1m50s

@dcadenas dcadenas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The receiver-preserving D1 batch call addresses the sync-failure recording error without changing username ownership or release semantics.
No actionable findings remained at ec9da72.

Checks

  • The receiver regression failed with the old invocation and passed with the fix.
  • npm run test:once: 496 tests passed; npm run typecheck passed.
  • Admin UI npm test: 29 tests and test typechecking passed; npm run build passed.
  • CI tests, Worker typechecking, admin tests/build, and the semantic-title validation step succeeded on this head. CLA and roborev checks also passed.

The local validation tool could not execute reusable workflows, the multi-command admin test, or watch mode directly.
The underlying test/build commands were covered separately, and the semantic check ran in CI.
Real local Worker HTTP/mobile integration and deployment were not exercised in this review; mobile integration remains separate from this focused receiver repair.

@NotThatKindOfDrLiz
NotThatKindOfDrLiz merged commit 9fbde88 into main Oct 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants