Repository navigation
fix(username): prevent release errors when recording sync failures - #115
Merged
Merged
Conversation
NotThatKindOfDrLiz
requested review from
a team,
dcadenas and
realmeylisdev
and removed request for
a team
October 3, 2026 23:47
roborev: Combined Review (
|
dcadenas
approved these changes
Oct 4, 2026
dcadenas
left a comment
Member
There was a problem hiding this comment.
The receiver-preserving D1 batch call addresses the sync-failure recording error without changing username ownership or release semantics.
No actionable findings remained at ec9da72.
Checks
- The receiver regression failed with the old invocation and passed with the fix.
npm run test:once: 496 tests passed;npm run typecheckpassed.- Admin UI
npm test: 29 tests and test typechecking passed;npm run buildpassed. - CI tests, Worker typechecking, admin tests/build, and the semantic-title validation step succeeded on this head. CLA and roborev checks also passed.
The local validation tool could not execute reusable workflows, the multi-command admin test, or watch mode directly.
The underlying test/build commands were covered separately, and the semantic check ran in CI.
Real local Worker HTTP/mobile integration and deployment were not exercised in this review; mobile integration remains separate from this focused receiver repair.
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Username release preparation returned HTTP 500 in the real local Worker runtime when Fastly sync was unavailable. Recording the sync failure called D1’s
batchmethod without its database receiver.Call
db.batchwith the receiver intact and add a receiver-sensitive regression test. Username ownership and release semantics are unchanged; there is no visual change.Validation: the regression failed before the fix; all 496 Worker tests and
npm run typecheckpass afterward. The mobile local-stack integration will exercise the real D1 runtime against this commit.Supports divinevideo/divine-mobile#7692 and divinevideo/divine-mobile#7691.