Dev - #28
Open
Elenetta17 wants to merge 3 commits into
Open
Dev#28Elenetta17 wants to merge 3 commits into
Elenetta17 wants to merge 3 commits into
Conversation
authenticate/readerLoop/writerLoop now use retina-commons' framing package instead of encoding/json, and model.ProbingDirective/ ForwardingInfoElement/Prober interface instead of api/v1 types. Real bugs found and fixed along the way, not just type renames: - validatePD: restored NearTTL==0 and NearTTL==255 checks that were silently dropped during migration (255 would wrap farTTL to 0, since NearTTL is uint8); split the combined ICMP/ICMPv6 header-presence check so an ICMP PD carrying an ICMPv6NextHeader (or vice versa) is correctly rejected instead of passing validation - buildFIE: SourceAddress now only taken from a probe result that actually succeeded, not a timed-out one that happens to carry one - processPD: nil-ProbeResult guard before recordProbeOutcome's unconditional dereference - a Prober returning (nil, nil) instead of (nil, ErrDuplicatePD) would otherwise panic under wg.Go - Run: net.Dialer.DialContext instead of net.Dial (ctx wasn't honored during connect); single cancellation watcher installed before authenticate (not just around the pipeline loops) so shutdown during the handshake is honored promptly too - readerLoop: errors.As instead of a direct net.Error type assertion for timeout classification - G115/exhaustive/copylocks/gocyclo lint fixes throughout cmd/mock-orchestrator: migrated alongside (framing/wire, same pattern) since it exchanges directives/FIEs with the agent directly and would otherwise be unable to speak to it at all post-migration. Depends on retina-commons with ForwardingInfoElement.SourceAddress optional (a PD whose near and far legs both time out has no reply data to derive a source address from). Verified end-to-end against the real retina-orchestrator binary. Signed-off-by: Elena Nardi <elena.nardi@lip6.fr>
Signed-off-by: Elena Nardi <elena.nardi@lip6.fr>
Signed-off-by: Elena Nardi <elena.nardi@lip6.fr>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 90.72% 90.79% +0.07%
==========================================
Files 8 8
Lines 1067 1086 +19
==========================================
+ Hits 968 986 +18
- Misses 87 90 +3
+ Partials 12 10 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.