Repository navigation
[fix][deploy] Auto-sync dev binaries; move cache node list to env - #1127
Merged
Merged
Conversation
Dev-mds scripts relied on manually copied binaries under dist/ and a hardcoded CACHE_NODE_LIST. Copy dingo-cache/dingo-client from build/bin on demand, load CACHE_NODE_LIST from the deploy env file, and default operate_mds replace_conf to true so config changes take effect.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the moderate startup/stop-path and clean-directory issues before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Updates dev deployment scripts to stage missing binaries, configure cache nodes via environment, and apply MDS configuration changes by default.
Changes:
- Stage client and cache binaries from
build/bin/when absent. - Load
CACHE_NODE_LISTfrom the deployment environment. - Enable configuration replacement by default.
| File | Summary |
|---|---|
scripts/dev-mds/start_client.sh |
Adds client binary staging; stop handling and clean-dist directory setup need correction. |
scripts/dev-mds/start_cache.sh |
Adds environment-based cache configuration and binary staging; stop handling should not require startup environment setup. |
scripts/dev-mds/operate_mds.sh |
Defaults configuration replacement to enabled. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+46
to
+50
| if [ ! -f "$mydir/${FLAGS_env}" ]; then | ||
| echo "error: env file not found: $mydir/${FLAGS_env}" | ||
| exit 1 | ||
| fi | ||
| source $mydir/${FLAGS_env} || exit 1 |
Comment on lines
+69
to
+78
| # check CLIENT_BIN_PATH exist | ||
| if [ ! -f "$CLIENT_BIN_PATH" ]; then | ||
| mkdir -p $CLIENT_BASE_DIR/bin | ||
| if [ ! -f "$SRC_CLIENT_BIN_PATH" ]; then | ||
| echo "not found dingo-client at $SRC_CLIENT_BIN_PATH" | ||
| exit 1 | ||
| fi | ||
|
|
||
| cp $SRC_CLIENT_BIN_PATH $CLIENT_BIN_PATH | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dev-mds scripts assumed binaries were already copied into
dist/and that the distributed cache node list was fixed at two hardcoded UUIDs. Neither is true on a fresh checkout or when the cache topology changes.start_cache.shandstart_client.shnow copydingo-cacheanddingo-clientfrombuild/bin/intodist/when the target is missing, andstart_cache.shreadsCACHE_NODE_LISTfrom the deploy env file (defaulting toenv.local) instead of embedding it.operate_mds.shnow defaultsreplace_conftotrue, so edited config is actually applied on restart instead of silently keeping the old file.Changes
start_cache.sh: loadCACHE_NODE_LISTfrom the deploy env file, create the cache log/bin dirs, and stage the binary frombuild/bin/on demand.start_client.sh: stagedingo-clientfrombuild/bin/whendist/client/binis empty; drop the unused conf/cache dir creation.operate_mds.sh: defaultreplace_conftotrue.Test plan
Run
bash scripts/dev-mds/operate_mds.sh start,start_cache.sh, andstart_client.shon a cleandist/: binaries should be staged automatically and the cache should pick up the node list from the env file.