Repository navigation
Conversation
dhilt
commented
Oct 8, 2026
dhilt
commented
Owner
- Preserve custom Routines across resets, creating fresh instances with updated settings.
- Rebind scroll listeners on reset and release them on disposal.
- Guard against synchronous scroll notifications during listener registration.
- Add regression tests for repeated/interrupted resets, viewport switching and disposal.
Guard against synchronous scroll notifications during registration.
Verify repeated and interrupted resets, viewport switching, disposal, and synchronous scroll notifications during registration.
Verify listener rebinding and disposal after reset interrupts a fetch. Simplify Routines coverage and remove redundant reset steps.
dhilt
deleted the
issue-78--adapter.reset()-drops-custom-Routines-and-keeps-the-scroll-listener-on-the-old-viewport
branch
October 11, 2026 14:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.