Skip to content

fix(examples): reuse the luma.gl device when StrictMode remounts DeckGlOverlay #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylebarron merged 1 commit into from
Sep 23, 2026
Merged

fix(examples): reuse the luma.gl device when StrictMode remounts DeckGlOverlay #668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions examples/_shared/components/deckgl-overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,29 @@ import { useControl } from "react-map-gl/maplibre";
* Drop inside a `<Map>` element: `<DeckGlOverlay layers={[layer]} interleaved />`.
*/
export function DeckGlOverlay(props: MapboxOverlayProps) {
const overlay = useControl<MapboxOverlay>(() => new MapboxOverlay(props));
overlay.setProps(props);
const overlay = useControl<MapboxOverlay>(
() => new MapboxOverlay(withReusedDevice(props)),
);
overlay.setProps(withReusedDevice(props));
return null;
}

/**
* Let a new `Deck` reuse a luma.gl device already attached to MapLibre's WebGL
* context instead of throwing.
*
* React `StrictMode` (development only) mounts this component twice, so the
* overlay creates a `Deck`, finalizes it, and immediately creates another on
* the same context. Both attach a device concurrently, and without
* `_reuseDevices` the second attach can throw "WebGL context already attached
* to device". deck.gl already passes this flag when it creates its own device
* ({@link https://github.com/visgl/deck.gl/blob/5eded84b438eef83387dc6579c51670389053602/modules/core/src/lib/deck.ts#L1469-L1473 | deck.ts#L1469-L1473}),
* but not when it attaches to an existing context, as in interleaved mode
* ({@link https://github.com/visgl/deck.gl/blob/5eded84b438eef83387dc6579c51670389053602/modules/core/src/lib/deck.ts#L434-L440 | deck.ts#L434-L440}).
*/
function withReusedDevice(props: MapboxOverlayProps): MapboxOverlayProps {
return {
...props,
deviceProps: { _reuseDevices: true, ...props.deviceProps },
};
}
Loading