Deprecate Split2 and OrderedSplit2#89
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 99.28% 99.25% -0.04%
==========================================
Files 15 15
Lines 697 667 -30
==========================================
- Hits 692 662 -30
Misses 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the introduction of
Teein v0.8, splitting no longer needs a dedicated operation — it can be composed from existing ones, and the composition isn't limited to two branches.When the predicate is a simple pure check, splitting is just
Tee+Filteron each branch:When the predicate is expensive, stateful, or can fail, evaluate it once per item before
Tee, tagging each item with the decision and routing on the tag:The same pattern extends to n-way splitting by tagging with an index or key instead of a bool.
The deprecated functions are now implemented as exactly this composition, so the existing Split2 tests validate the migration path until removal in v1.0.
Also mentions the upcoming v1.0 removal in DrainNB's deprecation notice.