feat(tenant): add patchTenant for partial tenant updates - #804
Conversation
Wraps PATCH /v1/mgmt/tenant/patch. Unlike update (full-replace), only explicitly provided fields are sent, so callers don't need to resupply every field to change one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
🐕 Suggested ReviewersThe PR adds a PATCH endpoint for partial tenant updates. dorsha has the most frequent involvement (20 commits) across test files and tenant management, making them ideal for defining test coverage & edge cases. orius123 contributed to paths.ts & index.ts, so they can verify API path registration and client initialization. aviadl touches tenant.ts & test.ts broadly, ensuring both the implementation and its tests are sound. itaihanski and LioriE only touched tenant tests, so they're good for reviewing test logic and consistency with lib changes.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
There was a problem hiding this comment.
🐕 Shuni Review
Adds patchTenant (PATCH /v1/mgmt/tenant/patch) so callers can update only the tenant fields they specify, instead of resending the full update payload.
Actionable comments posted: 2
- 2 🟡 Minor:
PatchTenantOptions.customAttributesand.roleInheritanceare typed looser than the equivalent fields oncreate/update, losing compile-time validation for this new API.
Merge risk: 🟢 Low: additive, well-tested change; findings are narrow type-safety gaps, not behavioral bugs.
See inline comments for details.
🤖 Model: claude-sonnet-5
Review scope: Full review
Reviewed files (4)
lib/index.tslib/management/paths.tslib/management/tenant.test.tslib/management/tenant.ts
Co-authored-by: shuni-bot[bot] <251468265+shuni-bot[bot]@users.noreply.github.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
Related Issues
related to https://github.com/descope/etc/issues/17551
Description
Wraps the management endpoint
PATCH /v1/mgmt/tenant/patchto support partial tenant structure updates.Must