Skip to content

feat(tenant): add patchTenant for partial tenant updates - #804

Merged
dorsha merged 3 commits into
mainfrom
feat/patch-tenant
Sep 1, 2026
Merged

feat(tenant): add patchTenant for partial tenant updates#804
dorsha merged 3 commits into
mainfrom
feat/patch-tenant

Conversation

@ruvenzx

@ruvenzx ruvenzx commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Related Issues

related to https://github.com/descope/etc/issues/17551

Description

Wraps the management endpoint PATCH /v1/mgmt/tenant/patch to support partial tenant structure updates.

Must

  • Tests
  • Documentation (if applicable)

Wraps PATCH /v1/mgmt/tenant/patch. Unlike update (full-replace), only
explicitly provided fields are sent, so callers don't need to resupply
every field to change one.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-sonnet-5

@shuni-bot

shuni-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🐕 Suggested Reviewers

The PR adds a PATCH endpoint for partial tenant updates. dorsha has the most frequent involvement (20 commits) across test files and tenant management, making them ideal for defining test coverage & edge cases. orius123 contributed to paths.ts & index.ts, so they can verify API path registration and client initialization. aviadl touches tenant.ts & test.ts broadly, ensuring both the implementation and its tests are sound. itaihanski and LioriE only touched tenant tests, so they're good for reviewing test logic and consistency with lib changes.

Reviewer Reason
dorsha Frequent contributor to tenant.test.ts and tenant.ts files; best suited to validate new patchTenant test coverage and integration with existing test suite.
orius123 Contributed to lib/management/paths.ts and lib/index.ts; can verify the new PATCH endpoint path registration and overall client initialization impact.
aviadl Touches paths.ts, test.ts, and tenant.ts; ensures consistency across path definitions, implementation, and test cases.
itaihanski Familiar with tenant test files from previous commits; can review test logic and consistency when integrating new patchTenant tests.
LioriE Previously contributed to tenant tests; good for ensuring test coverage passes and tests align with the new implementation.

Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni Review

Adds patchTenant (PATCH /v1/mgmt/tenant/patch) so callers can update only the tenant fields they specify, instead of resending the full update payload.

Actionable comments posted: 2

  • 2 🟡 Minor: PatchTenantOptions.customAttributes and .roleInheritance are typed looser than the equivalent fields on create/update, losing compile-time validation for this new API.

Merge risk: 🟢 Low: additive, well-tested change; findings are narrow type-safety gaps, not behavioral bugs.

See inline comments for details.

🤖 Model: claude-sonnet-5


Review scope: Full review

Reviewed files (4)
  • lib/index.ts
  • lib/management/paths.ts
  • lib/management/tenant.test.ts
  • lib/management/tenant.ts

Comment thread lib/management/tenant.ts Outdated
Comment thread lib/management/tenant.ts Outdated
@ruvenzx ruvenzx self-assigned this Sep 1, 2026
Co-authored-by: shuni-bot[bot] <251468265+shuni-bot[bot]@users.noreply.github.com>
@shuni-bot

shuni-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-sonnet-5

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni Review

No new issues found.

🤖 Model: claude-sonnet-5


Review scope: Incremental re-review

Reviewed new changes (1)
  • lib/management/tenant.ts
Previously reviewed and unchanged: 3 files.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-sonnet-5

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni Review

No new issues found.

🤖 Model: claude-sonnet-5


Review scope: Incremental re-review

Reviewed new changes (1)
  • README.md
Previously reviewed and unchanged: 4 files.

@ruvenzx
ruvenzx requested a review from dorsha September 1, 2026 07:44
@dorsha
dorsha merged commit 399397e into main Sep 1, 2026
29 checks passed
@dorsha
dorsha deleted the feat/patch-tenant branch September 1, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants