feat(auth): support enchanted link over SMS - #370
Open
eliran-descope wants to merge 3 commits into
Open
Conversation
Adds signInWithPhone, signUpWithPhone (two overloads), signUpOrInWithPhone and updateUserPhone (two overloads) to EnchantedLinkService, targeting the four /v1/auth/enchantedlink/**/sms routes. The SMS routes return the backend's distinct PhoneEnchantedLinkResponse message, so a new model class carries maskedPhone rather than widening EnchantedLinkResponse, whose all-args constructor arity stays intact.
Author
|
@shuni review |
Contributor
🐕 Shuni ReviewAdds SMS enchanted-link authentication and phone updates while preserving the existing signup-request constructor. Actionable comments posted: 0 — no new actionable issues verified. Merge risk: 🟡 Moderate: Shared-helper changes also affect existing email sign-in and signup flows. 🤖 Model: Review scope: Partial review Reviewed files (6)
Deliberately skipped (1)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
![shuni-bot[bot]](https://avatars.githubusercontent.com/in/2536750?s=60&v=4){kind=small}
Moved the new phone field to the end of SignUpRequest and re-added the original five-argument constructor as an overload delegating with a null phone. Inserting phone mid-list changed Lombok's generated constructor arity and parameter order, breaking external callers at compile time and precompiled ones with NoSuchMethodError. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tygd97fhsqkojmDTnr1aVj
Author
|
@shuni review |
eliran-descope
marked this pull request as ready for review
September 10, 2026 10:40
eliran-descope
marked this pull request as draft
September 10, 2026 11:04
The enchanted link intro was widened to mention the phone variants while still claiming the message carries three links. Over SMS only the correct link is sent, so the intro now covers email alone and the SMS paragraph states that there is nothing for the user to choose.
eliran-descope
marked this pull request as ready for review
September 10, 2026 11:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Enchanted Link over SMS to descope-java.
SignUpRequestgains aphonefield, appended last, with the original 5-arg constructor kept as an overload — no break for existing callers.Part of descope/etc#18315