Repository navigation
fix(ext/node): support options-only overload in util.getCallSites - #37141
Open
Sun-Wukhan wants to merge 2 commits into
Open
Sun-Wukhan wants to merge 2 commits into
Sun-Wukhan wants to merge 2 commits into
Conversation
Signed-off-by: Navid Khan (Ali) <60997541+Sun-Wukhan@users.noreply.github.com>
Signed-off-by: Navid Khan (Ali) <60997541+Sun-Wukhan@users.noreply.github.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37136
util.getCallSites()validated the first argument asframeCountunconditionally, so the options-only overload that the type declarations accept (and Node accepts) threwERR_INVALID_ARG_TYPE. Provided options were also validated only when truthy, sogetCallSites(10, null),(10, false),(10, 0)and(10, "")were silently accepted instead of being rejected.This restructures the argument handling to match Node's
lib/util.js: whenoptionsis omitted and the first argument is an object, it is treated as the options object with the default frame count of 10. Provided options are always validated withvalidateObject, andoptions.sourceMapis validated withvalidateBooleanwhen present. Deno's existingvalidateNumberrange forframeCount(0 to 200) is unchanged.Adds a unit test covering the options-only overload, the default frame count, and rejection of falsy or invalid options. Behaviour was checked against Node v24 for the affected call shapes, and the bug was reproduced on Deno 2.9.8 before the change.
AI disclosure: this PR was prepared with AI assistance (Claude), as required by the contributing guidelines.