Skip to content

docs: fix initalize/seperately/sucessfully typos #37138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ninglinLiu wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Open

docs: fix initalize/seperately/sucessfully typos #37138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions libs/core/runtime/jsruntime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ pub(crate) const NO_OF_BUILTIN_MODULES: usize = 2;
/// Use [`JsRuntimeForSnapshot`] to be able to create a snapshot.
///
/// Note: since V8 11.6, all runtimes must have a common parent thread that
/// initalized the V8 platform. This can be done by calling
/// initialized the V8 platform. This can be done by calling
/// [`JsRuntime::init_platform`] explicitly, or it will be done automatically on
/// the calling thread when the first runtime is created.
pub struct JsRuntime {
Expand Down Expand Up @@ -727,15 +727,15 @@ macro_rules! scope {
}

impl JsRuntime {
/// Explicitly initalizes the V8 platform using the passed platform. This
/// Explicitly initializes the V8 platform using the passed platform. This
/// should only be called once per process. Further calls will be silently
/// ignored.
#[cfg(not(any(test, feature = "unsafe_runtime_options")))]
pub fn init_platform(v8_platform: Option<v8::SharedRef<v8::Platform>>) {
setup::init_v8(v8_platform, cfg!(test), false);
}

/// Explicitly initalizes the V8 platform using the passed platform. This
/// Explicitly initializes the V8 platform using the passed platform. This
/// should only be called once per process. Further calls will be silently
/// ignored.
///
Expand Down Expand Up @@ -2051,7 +2051,7 @@ impl JsRuntime {
/// event loop resolves the underlying promise. If the future rejects, the future will
/// resolve with the underlying error.
///
/// The event loop must be polled seperately for this future to resolve. If the event loop
/// The event loop must be polled separately for this future to resolve. If the event loop
/// is not polled, the future will never make progress.
pub fn call(
&mut self,
Expand All @@ -2066,7 +2066,7 @@ impl JsRuntime {
/// event loop resolves the underlying promise. If the future rejects, the future will
/// resolve with the underlying error.
///
/// The event loop must be polled seperately for this future to resolve. If the event loop
/// The event loop must be polled separately for this future to resolve. If the event loop
/// is not polled, the future will never make progress.
pub fn scoped_call(
scope: &mut v8::PinScope,
Expand All @@ -2081,7 +2081,7 @@ impl JsRuntime {
/// event loop resolves the underlying promise. If the future rejects, the future will
/// resolve with the underlying error.
///
/// The event loop must be polled seperately for this future to resolve. If the event loop
/// The event loop must be polled separately for this future to resolve. If the event loop
/// is not polled, the future will never make progress.
pub fn call_with_args(
&mut self,
Expand All @@ -2098,7 +2098,7 @@ impl JsRuntime {
/// event loop resolves the underlying promise. If the future rejects, the future will
/// resolve with the underlying error.
///
/// The event loop must be polled seperately for this future to resolve. If the event loop
/// The event loop must be polled separately for this future to resolve. If the event loop
/// is not polled, the future will never make progress.
pub fn scoped_call_with_args(
scope: &mut v8::PinScope,
Expand Down
4 changes: 2 additions & 2 deletions tools/release/release_doc_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ Release checklist: <LINK TO THIS FORKED GIST GOES HERE>
https://github.com/denoland/deno_docker/actions/workflows/version_bump.yml
- [ ] This will open a PR. Review and merge it.
- [ ] Create a `$VERSION` tag (_without_ `v` prefix).
- [ ] This will trigger a publish CI run. Verify that it completes sucessfully.
- [ ] This will trigger a publish CI run. Verify that it completes successfully.

## Updating `deno_pypi`

Expand All @@ -117,7 +117,7 @@ Release checklist: <LINK TO THIS FORKED GIST GOES HERE>
- [ ] This will open a PR. Review and merge it.
- [ ] Run the release workflow:
https://github.com/denoland/deno_pypi/actions/workflows/release.yml
- [ ] This will trigger a publish CI run. Verify that it completes sucessfully
- [ ] This will trigger a publish CI run. Verify that it completes successfully
and new version is available at https://pypi.org/project/deno/.

## Update MDN
Expand Down