Repository navigation
feat(cli): support --external with deno compile --bundle - #37137
Open
jipeng6036-del wants to merge 1 commit into
Open
jipeng6036-del wants to merge 1 commit into
jipeng6036-del wants to merge 1 commit into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #37126.
deno compile --bundlecan fail on an optional dependency before the program starts. Add a repeatable--external <specifier>option so compile uses the same matcher asdeno bundle, including for worker bundles. Keep native addons and the npm packages still imported by the bundle available in the standalone executable.On Linux, the reporter's Playwright example compiles and prints
functionwith:Externalizing only
chromium-bidi/*lets the build finish, but the inlined Playwright code still reaches its existing CommonJS__dirnameerror. The guardednode:seaexample compiles and printsnot a SEAwith--external=node:sea.Validation: 387 CLI parser tests, 11 compile bundle specs, Linux builds of
denoanddenort, repository format check, and the Rust and JavaScript lint checks. The standalone smoke tests ran the generated executables on Linux.AI disclosure: OpenAI Codex assisted with implementation, testing, and drafting this description.