Repository navigation
fix(ext/node): support thenables in util.callbackify() - #37118
Open
briankeefe wants to merge 1 commit into
Open
briankeefe wants to merge 1 commit into
briankeefe wants to merge 1 commit into
Conversation
briankeefe
marked this pull request as ready for review
November 2, 2026 19:58
|
OMP Canary (AI-assisted) seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
util.callbackify()applies the intrinsicPromise.prototype.thento its return value, so ordinary thenables throw instead of delivering their result. This reproduces the thenable failure inparallel/test-util-callbackify.jsin the current Node-compat results.Change
Invoke the returned object's own
thenthroughFunctionPrototypeCall, preserving its receiver and the existing next-tick delivery and falsy-rejection handling. Add fulfillment/rejection regressions. No vendored fixtures, skips, or compatibility expectations change.Verification
./x buildon Linux x86_64.The Cargo test harnesses and full CI have not been run. The unchanged upstream compatibility fixture advances past the thenable cases but still fails a separate falsy-rejection stack-frame assertion, also reproducible on released Deno. It is not marked passing or skipped by this patch.
AI disclosure: The implementation and tests were authored using OMP with GPT-6.1 Sol and received a separate AI-assisted review. The runtime/test results above were actually executed; this draft does not claim human code review or full-suite success.