Skip to content

fix(pack): exclude existing package.json from assets #36507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rathodkunj2005 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(pack): exclude existing package.json from assets #36507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa420e4
fix(pack): exclude existing package.json from assets
rathodkunj2005 Aug 8, 2026
0ff7188
ci: retrigger checks
rathodkunj2005 Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cli/tools/pack/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,10 +474,12 @@ fn collect_asset_files(
excluded.insert(p);
}
}
// The source config file is replaced by the generated package.json.
// The source config file and any existing package.json are replaced by the
// generated package.json.
if let Ok(p) = package.config_file.specifier.to_file_path() {
excluded.insert(p);
}
excluded.insert(package_dir.join("package.json"));
// README/LICENSE are added by `collect_readme_license_files`.
for file in readme_license_files {
excluded.insert(package_dir.join(&file.relative_path));
Expand Down
4 changes: 2 additions & 2 deletions tests/specs/pack/package_json_content/__test__.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"pack_package_json_content": {
"steps": [{
"args": "pack",
"output": "[WILDCARD]✓[WILDCARD]test-pkg-json-1.0.0.tgz[WILDCARD]"
"output": "[WILDCARD]0 assets collected[WILDCARD]✓[WILDCARD]test-pkg-json-1.0.0.tgz[WILDCARD]"
}, {
"if": "unix",
"commandName": "bash",
"args": [
"-c",
"tar -xzf test-pkg-json-1.0.0.tgz && cat package/package.json && echo"
"test \"$(tar -tzf test-pkg-json-1.0.0.tgz | grep -c '^package/package.json$')\" -eq 1 && tar -xzf test-pkg-json-1.0.0.tgz && cat package/package.json && echo"
],
"output": "package_json.out"
}]
Expand Down
4 changes: 4 additions & 0 deletions tests/specs/pack/package_json_content/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "source-package-json",
"private": true
}
Loading