Skip to content

fix: log block eigenvalue summary events#8048

Open
he-yufeng wants to merge 1 commit into
deepspeedai:masterfrom
he-yufeng:fix/eigenvalue-summary-events
Open

fix: log block eigenvalue summary events#8048
he-yufeng wants to merge 1 commit into
deepspeedai:masterfrom
he-yufeng:fix/eigenvalue-summary-events

Conversation

@he-yufeng

Copy link
Copy Markdown

Summary

  • use the eigenvalues from self.block_eigenvalue.values() when building monitor summary events
  • avoid indexing the Python 3 dict_values view
  • add focused coverage for the eigenvalue summary-event path without constructing a full engine

Fixes #7983.

To verify

  • python -m py_compile deepspeed\runtime\engine.py tests\unit\runtime\test_engine.py (passed)
  • git diff --check (passed)
  • python -m pytest tests\unit\runtime\test_engine.py -q was attempted on Windows, but collection failed before the test ran because this clone has core.symlinks=false and deepspeed/accelerator was checked out as a plain text symlink file, so deepspeed.accelerator cannot be imported locally. The new test should run in the normal Linux checkout used by CI.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf89862488

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +1 to +2
# Copyright (c) Microsoft Corporation.
# SPDX-License-Identifier: Apache-2.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required DeepSpeed Team header

In this new test file, the workspace AGENTS.md requires new files to include the license header # SPDX-License-Identifier: Apache-2.0 followed by # DeepSpeed Team; this header omits # DeepSpeed Team and adds a different first line, so it violates the repo's required new-file header.

Useful? React with 👍 / 👎.

@he-yufeng he-yufeng force-pushed the fix/eigenvalue-summary-events branch from cf89862 to 7df7988 Compare June 6, 2026 19:10
@he-yufeng

Copy link
Copy Markdown
Author

Rebased this branch onto the latest upstream master and force-pushed the cleaned head. I also amended the commit with DCO signoff to clear the Signed-off-by requirement.

Validated locally:

  • python -m py_compile deepspeed/runtime/engine.py tests/unit/runtime/test_engine.py
  • git diff --check origin/master..HEAD
  • git log --format=%B -1 includes Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>

I also retried the focused pytest target:

  • python -m pytest -q tests/unit/runtime/test_engine.py

That still fails during collection in this Windows checkout before running the test because deepspeed/accelerator is checked out locally as a small link file containing ../accelerator/, so importing deepspeed.accelerator fails. The previous Linux CI did run the DeepSpeed job; the new push should let CI rerun after the rebase/signoff update.

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
@he-yufeng he-yufeng force-pushed the fix/eigenvalue-summary-events branch from 7df7988 to 8ad8706 Compare June 16, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect variable name: self.ev_values

1 participant