Ignore C# build stuff - #19
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds support for reading and respecting .gitignore patterns in the examples folder during test plan building. The primary motivation is to prevent C# build artifacts (like bin/ and obj/ directories) from being incorrectly processed as test files, which was causing test failures. The PR also adds the C# solution file astra-client-docs-tests.sln to the root .gitignore.
Changes:
- Added
.gitignorepattern parsing and filtering to skip files matching gitignore patterns in the examples directory - Added
astra-client-docs-tests.slnto the root.gitignorefile - Implemented gitignore-style glob pattern to regex conversion
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| .gitignore | Added C# solution file to be ignored at the repository root |
| src/main/java/com/dtsx/docs/core/planner/TestPlanBuilder.java | Implemented .gitignore file reading, pattern parsing, and file filtering logic with new helper methods and updated existing methods to use gitignore filtering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix from bob to avoid the following error. Also giignore the generated sln file